Skip to content

chore(pdp): add ExternalUrl for IPNI to be announced correctly [DO NOT MERGE] #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: pdpv0
Choose a base branch
from
Open

chore(pdp): add ExternalUrl for IPNI to be announced correctly [DO NOT MERGE] #810

wants to merge 1 commit into from

Conversation

@beck-8
Copy link
Contributor

@beck-8 beck-8 commented Nov 20, 2025

#786

image 
2025-11-20T21:27:13.578+0800    INFO    ipni-provider   ipni-provider/ipni-provider.go:147      ipni peer ID    {"peerID": "12D3KooWPRuubsz8p49yAFBZGwsKVEF9MqxN1CQ1QRMeaDE4VCZu"}
2025-11-20T21:27:13.578+0800    INFO    ipni-provider   ipni-provider/ipni-provider.go:197      Announce address        {"address": "/dns/pdp.660688.xyz/tcp/8880/http/http-path/%2Fipni-provider%2F12D3KooWPRuubsz8p49yAFBZGwsKVEF9MqxN1CQ1QRMeaDE4VCZu", "pid": "12D3KooWPRuubsz8p49yAFBZGwsKVEF9MqxN1CQ1QRMeaDE4VCZu", "url": "http://pdp.660688.xyz:8880/ipni-provider/12D3KooWPRuubsz8p49yAFBZGwsKVEF9MqxN1CQ1QRMeaDE4VCZu"}
2025-11-20T21:27:13.578+0800    INFO    ipni-provider   ipni-provider/ipni-provider.go:527      Starting IPNI provider publishing for testnet build

@beck-8 beck-8 requested a review from a team as a code owner November 20, 2025 13:42
@LexLuthr
Copy link
Contributor

LexLuthr commented Nov 20, 2025

This is not the correct approach to handle #786. Also, #786 is not yet triaged or decided upon.

@LexLuthr LexLuthr changed the title chore(pdp): add ExternalUrl for IPNI to be announced correctly chore(pdp): add ExternalUrl for IPNI to be announced correctly [DO NOT MERGE] Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beck-8 @LexLuthr